-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated test to build binary locally based on variable value #569
Conversation
330ac94
to
92c4d45
Compare
hack/test-all.sh
Outdated
@@ -2,7 +2,10 @@ | |||
|
|||
set -e -x -u | |||
|
|||
./hack/build.sh | |||
if [ ${BUILD_LOCAL:-true} == true ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename it to BUILD_BINARY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
hack/test-all.sh
Outdated
@@ -2,7 +2,10 @@ | |||
|
|||
set -e -x -u | |||
|
|||
./hack/build.sh | |||
if [ ${BUILD_LOCAL:-true} == true ]; then | |||
echo "build-local" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove echo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -2,7 +2,10 @@ | |||
|
|||
set -e -x -u | |||
|
|||
./hack/build.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment which says how to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: kumari tanushree <ktanushree@vmware.com>
92c4d45
to
2f9e4f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick v0.36.x |
Updated test to build binary locally based on variable value
/cherry-pick v0.33.x |
Updated test to build binary locally based on variable value
/cherry-pick v0.31.x |
Updated test to build binary locally based on variable value
Merge pull request #569 from carvel-dev/update-optional-build-test Updated test to build binary locally based on variable value
Merge pull request #569 from carvel-dev/update-optional-build-test Updated test to build binary locally based on variable value
Merge pull request #569 from carvel-dev/update-optional-build-test Updated test to build binary locally based on variable value
Updated test to build binary locally based on variable value. Default it is set to true. If you do not want to build binary through test-all.sh run:
export BUILD_LOCAL=false