Reverse the order of extraction of layers #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
|
Any chance anyone has had to look at this? |
joaopapereira
force-pushed
the
reverse-extraction-order
branch
from
05d129a
to
5452eb3
Compare
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
joaopapereira
force-pushed
the
reverse-extraction-order
branch
from
5452eb3
to
9206ad7
Compare
joaopapereira
had a problem deploying
to
TanzuNet Registry Dev e2e
GitHub Actions
Failure
joaopapereira
had a problem deploying
to
GCR e2e
GitHub Actions
Failure
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
praveenrewar
reviewed
Feb 5, 2024
pkg/imgpkg/image/dir_image.go
Outdated
| func inWhiteoutDir(fileMap map[string]bool, file string) bool { | ||
| for { | ||
| if file == "" { | ||
| break |
pkg/imgpkg/image/dir_image.go
Outdated
| } | ||
| dirname := filepath.Dir(file) | ||
| if file == dirname { | ||
| break |
| @@ -41,8 +41,8 @@ images: | |||
| kbld.carvel.dev/id: cloudfoundry/syslog-server@sha256:bb1aa0d603eff716245f25c832ad9b9bca569059f48bd2b5a9a792486f453427 | |||
| image: index.docker.io/cloudfoundry/syslog-server@sha256:bb1aa0d603eff716245f25c832ad9b9bca569059f48bd2b5a9a792486f453427 | |||
| - annotations: | |||
| kbld.carvel.dev/id: gcr.io/paketo-community/python@sha256:5fc81b8f38f326f0247468c14b4eb66b36e5f925db12f9ea8df1ec57f9e61d94 | |||
| image: gcr.io/paketo-community/python@sha256:5fc81b8f38f326f0247468c14b4eb66b36e5f925db12f9ea8df1ec57f9e61d94 | |||
| kbld.carvel.dev/id: index.docker.io/paketocommunity/python/python@sha256:1228cfb8003f830b178b9b8a227889cae32df1aed74a746f2ac59b6bb8e88961 | |||
There was a problem hiding this comment.
Do we want to merge this in a separate PR first because we might want to cherry pick this to some other branches too.
There was a problem hiding this comment.
I was expecting this to be merged soon so I just added as part of this PR
Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: Joao Pereira <joaod@vmware.com>
joaopapereira
force-pushed
the
reverse-extraction-order
branch
from
e486638
to
6c33160
Compare
joaopapereira
temporarily deployed
to
TanzuNet Registry Dev e2e
GitHub Actions
Inactive
praveenrewar
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #441