Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache app names while printing ownership errors #998

Open
100mik opened this issue Aug 5, 2024 · 0 comments
Open

Cache app names while printing ownership errors #998

100mik opened this issue Aug 5, 2024 · 0 comments
Assignees
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@100mik
Copy link
Contributor

100mik commented Aug 5, 2024

Describe the problem/challenge you have
Today kapp makes a call per resource when it encounters multiple resources owned by another app. This can be a an issue if a PackageInstall is constantly failing with this error for multiple resources.

Describe the solution you'd like
We are already building a map while snatching ownership from specified apps. We can reuse this to mitigate this risk.

Anything else you would like to add:
There is a very slight chance of an app being created after we have cached the information. But it is an unlikely race condition, and the only downside is that app won't be named in the error message. This will change in the next reconciliation when the name is cached.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@100mik 100mik added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Aug 5, 2024
@renuy renuy added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Aug 30, 2024
@devanshuVmware devanshuVmware self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

3 participants