From e16bfdfac80ea3fac119f369e6e9df1b0b1d8079 Mon Sep 17 00:00:00 2001 From: Michael Freeman Date: Sat, 5 Oct 2024 21:33:48 -0500 Subject: [PATCH] fixing linter problems --- pkg/eventingest/errors.go | 5 +++++ pkg/eventingest/http_server_test.go | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/pkg/eventingest/errors.go b/pkg/eventingest/errors.go index a500c29..eb7ac81 100644 --- a/pkg/eventingest/errors.go +++ b/pkg/eventingest/errors.go @@ -5,6 +5,11 @@ import ( "net/http" ) +var ( + errInvalidJSON = NewProcessingError("Invalid JSON") + errForwardFail = NewProcessingError("Failed to forward event") +) + // CustomError is a custom error type that includes an HTTP status code. type CustomError struct { Message string diff --git a/pkg/eventingest/http_server_test.go b/pkg/eventingest/http_server_test.go index 0fb70ee..5155c77 100644 --- a/pkg/eventingest/http_server_test.go +++ b/pkg/eventingest/http_server_test.go @@ -1,7 +1,6 @@ package eventingest import ( - "errors" "testing" customctx "github.com/carverauto/eventrunner/pkg/context" @@ -75,7 +74,7 @@ func TestHandleEvent(t *testing.T) { mockCtx.EXPECT().GetUUIDClaim("tenant_id").Return(uuid.New(), true) mockCtx.EXPECT().GetUUIDClaim("customer_id").Return(uuid.New(), true) - mockCtx.EXPECT().Bind(gomock.Any()).Return(errors.New("invalid JSON")) + mockCtx.EXPECT().Bind(gomock.Any()).Return(errInvalidJSON) return mockCtx, mockEF }, @@ -97,7 +96,7 @@ func TestHandleEvent(t *testing.T) { mockCtx.EXPECT().Bind(gomock.Any()).SetArg(0, eventData).Return(nil) mockCtx.EXPECT().Context().Return(&gofr.Context{}) - mockEF.EXPECT().ForwardEvent(gomock.Any(), tenantID, customerID, eventData).Return(errors.New("forwarding failed")) + mockEF.EXPECT().ForwardEvent(gomock.Any(), tenantID, customerID, eventData).Return(errForwardFail) return mockCtx, mockEF },