Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix typo and specified owner in methods that used _options.Organ… #66

Closed
wants to merge 1 commit into from
Closed

fix: fix typo and specified owner in methods that used _options.Organ… #66

wants to merge 1 commit into from

Conversation

d1mak3
Copy link
Contributor

@d1mak3 d1mak3 commented Aug 30, 2023 •
edited
Loading

No description provided.

@casbin-bot
Copy link

@seriouszyx @ComradeProgrammer @Resulte please review

@sagilio
Copy link
Collaborator

sagilio commented Aug 30, 2023

Hi, May I ask what is different about #65?

@sagilio sagilio self-assigned this Aug 30, 2023
@sagilio sagilio added the enhancement New feature or request label Aug 30, 2023
@d1mak3
Copy link
Contributor Author

d1mak3 commented Aug 30, 2023 •
edited
Loading

Hi, May I ask what is different about #65?

Hello. Nothing much to be honest, just different APIs, because I didn't see this thing in other APIs at first. Should I create new PR with such fix in every API and close this one and #65?

@sagilio
Copy link
Collaborator

sagilio commented Aug 30, 2023

Hi, May I ask what is different about #65?

Hello. Nothing much to be honest, just different APIs, because I didn't see this thing in other APIs at first. Should I create new PR with such fix in every API and close this one and #65?

I find that #65 includes all changes in this PR. We may merge the #65 and close this PR.

@d1mak3
Copy link
Contributor Author

d1mak3 commented Aug 30, 2023

Hi, May I ask what is different about #65?

Hello. Nothing much to be honest, just different APIs, because I didn't see this thing in other APIs at first. Should I create new PR with such fix in every API and close this one and #65?

I find that #65 includes all changes in this PR. We may merge the #65 and close this PR.

My bad, it does include all changes, sorry. So yeah that would be great tyvm

@hsluoyz
Copy link
Member

hsluoyz commented Aug 31, 2023

Replaced by: #65

@hsluoyz hsluoyz closed this Aug 31, 2023
@d1mak3 d1mak3 deleted the dev1 branch August 31, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@Resulte Resulte Awaiting requested review from Resulte

@seriouszyx seriouszyx Awaiting requested review from seriouszyx

Assignees

@sagilio sagilio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d1mak3 @casbin-bot @sagilio @hsluoyz