Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use getter method replace direct #73

Closed
wants to merge 1 commit into from

Conversation

dlarmor
Copy link

@dlarmor dlarmor commented Nov 17, 2023

No description provided.

@casbin-bot
Copy link

@seriouszyx @ComradeProgrammer @Resulte please review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz
Copy link
Member

hsluoyz commented Nov 17, 2023

@dlarmor why change this?

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (ecb7b0b) 0.00% compared to head (8b37783) 0.00%.

Files Patch % Lines
.../main/java/org/casbin/casdoor/service/Service.java 0.00% 21 Missing ⚠️
...n/java/org/casbin/casdoor/service/AuthService.java 0.00% 11 Missing ⚠️
...n/java/org/casbin/casdoor/service/UserService.java 0.00% 9 Missing ⚠️
...va/org/casbin/casdoor/service/EnforcerService.java 0.00% 8 Missing ⚠️
.../org/casbin/casdoor/service/PermissionService.java 0.00% 7 Missing ⚠️
...va/org/casbin/casdoor/service/ProviderService.java 0.00% 5 Missing ⚠️
...n/java/org/casbin/casdoor/service/RoleService.java 0.00% 5 Missing ⚠️
...ava/org/casbin/casdoor/service/SessionService.java 0.00% 5 Missing ⚠️
...ava/org/casbin/casdoor/service/AdapterService.java 0.00% 4 Missing ⚠️
...n/java/org/casbin/casdoor/service/CertService.java 0.00% 4 Missing ⚠️
... and 17 more
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #73   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          81      81           
  Lines        1150    1158    +8     
  Branches       29      29           
======================================
- Misses       1150    1158    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlarmor
Copy link
Author

dlarmor commented Nov 18, 2023

@hsluoyz Emmm, it's better for enhancement. If anyone wants to adjust some logic, they can simply override the getter method.

eg:
if i want change organization name logic in config, just override getOrganizationName() in my custom config extends
image

@hsluoyz
Copy link
Member

hsluoyz commented Nov 18, 2023

@dlarmor can simply override the getter method is only your imagination and we will never do that. Because we use same logic for all SDKs like Go, .NET, Python, etc. And those languages don't have getters like Java. We won't make Java more different.

@hsluoyz hsluoyz closed this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants