fix(plan): add missing paymentProviders field and update options data… #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type ### Description This PR addresses the following issues in the `Plan` entity of the Java Casdoor SDK: - Added: The missing `paymentProviders` field, which is required to match the Golang implementation. This field is defined as a `String[]` in the Golang code. - Updated: The data type of the `options` field to `String[]`, ensuring compatibility with the expected data types in the Golang codebase. ### Changes Made - Introduced a new field `public String[] paymentProviders;` in the `Plan` class. - Changed the data type of the `options` field to `public String[] options;. ### Related Issue This PR addresses the mismatch between the Java and Golang implementations regarding the `Plan` entity. Please review the changes and let me know if there are any suggestions or concerns.
|
@tangyang9464 @imp2002 please review |
|
|
|
@tangyang9464 Thank you for your assistance and for providing such a valuable tool. |
|
Replaced by: 9361a85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… type
Description
This PR addresses the following issues in the
Planentity of the Java Casdoor SDK:paymentProvidersfield, which is required to match the Golang implementation. This field is defined as aString[]in the Golang code.optionsfield toString[], ensuring compatibility with the expected data types in the Golang codebase.Changes Made
public String[] paymentProviders;in thePlanclass.optionsfield to `public String[] options;.Related Issue
This PR addresses the mismatch between the Java and Golang implementations regarding the
Planentity.Please review the changes and let me know if there are any suggestions or concerns.