Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deprecated: Creation of dynamic property" warnings with PHP 8.2 #781

Closed
LMachucaORT opened this issue Oct 31, 2023 · 6 comments
Closed

Comments

@LMachucaORT
Copy link

LMachucaORT commented Oct 31, 2023

PHP Deprecated: Creation of dynamic property auth_saml2\admin\setting_button::$label is deprecated in auth/saml2/classes/admin/setting_button.php on line 52
PHP Deprecated: Creation of dynamic property auth_saml2\admin\setting_button::$href is deprecated in auth/saml2/classes/admin/setting_button.php on line 53

PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$spname is deprecated in auth/saml2/classes/auth.php on line 111
PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$certpem is deprecated in auth/saml2/classes/auth.php on line 112
PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$certcrt is deprecated in auth/saml2/classes/auth.php on line 113
PHP Deprecated: Creation of dynamic property auth_plugin_saml2::$metadatalist is deprecated in auth/saml2/classes/auth.php on line 119

@sammarshallou
Copy link
Contributor

We see this too, I'll submit a fix shortly.

sammarshallou added a commit to sammarshallou/moodle-auth_saml2 that referenced this issue Nov 21, 2023
sammarshallou added a commit to sammarshallou/moodle-auth_saml2 that referenced this issue Nov 21, 2023
@gemguardian
Copy link

@sammarshallou - I wonder if there is a timeline on when to saml2 php 8.2 version will be available?

@sammarshallou
Copy link
Contributor

@gemguardian No use asking me, that's down to Catalyst. We are using it here in PHP 8.2; according to our customisation notes we only have the published plugin, plus PR #789 which is the one linked here, (And one other local change which is because our login IdP has a bug, not related to PHP 8.2.)

@gemguardian
Copy link

@sammarshallou thank you for the information, sorry I mixed up names thought you worked for Catalyst. @danmarsden then I am tagging you - do you have any idea if Catalyst will commit the pull request ?

@danmarsden
Copy link
Member

just merged it in.. there's a bit of a backlog on pull requests in here at the moment - hard to find someone internally with the time to test and review stuff on non-chargeable time these days... and my work day should have been long over by now too!! :-)

Thanks for the pr Sam (and for the reminder @gemguardian) :-)

@gemguardian
Copy link

@danmarsden thank you. Fully understand :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants