Added required suffix for custom completion rule in 4.3+ #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @opitz - our typical preference is to create a new branch instead of writing if version X do Y type code as it increases technical debt. If you get a chance, feel free to update the PR so that it just includes the changes required for 4.3 - feel free to make the pr against our MOODE_400_STABLE branch and we'll create a new 4.3 branch to merge it into. thanks! |
opitz
force-pushed
the
MOODLE_403_STABLE
branch
from
0a4eab4 to
58a979d
Compare
opitz
force-pushed
the
MOODLE_403_STABLE
branch
from
58a979d to
b8c0f15
Compare
|
@danmarsden fixed now (or so I hope...). |
danmarsden
changed the base branch from
MOODLE_400_STABLE
to
MOODLE_403_STABLE
|
thanks - I've created a new 4.3 branch and merged that in! |
|
looks like we still have some behat failures on the 4.3 branch, hopefully someone will get a chance to look at those sometime |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a suffix to the custom completion rule in mod_form.php.
This will fix #140.