Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#147] Pass context to user selectors #148

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Apr 21, 2024

Closes #147

Simple fix for issue, just passing in the correct context. Note the context is course context, not course module context, because this appears to be what the rest of the page is using.

Testing
Logged in as user with moodle/site:viewuseridentity in course context, but not system context. showuseridentity config has email selected to show. On the attendees sign up page.

Before (no emails shown):

image

After (emails shown - good):

image

TODO

@keevan keevan merged commit c676005 into MOODLE_403_STABLE Apr 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context not passed to user selectors
2 participants