feat: bulk book users to sessions via csv file #151

keevan · 2024-05-01T06:04:34Z

Summary:

permission check to only allow users with this permission to do so
can intially set notification type, status (booked/cancelled) and
discount code.
tests for various scenarios.
managed via a booking manager class.
supports both csv file and array (list of bookings) formats.

Resolves #150

TODO:

add event handling(?)

keevan · 2024-05-02T05:25:34Z

Pulled in some changes found in 403, goal is that the behat issues have already been resolved.

classes/booking_manager.php

classes/form/confirm_bookings_form.php

classes/form/upload_bookings_form.php

upload.php

danmarsden · 2024-05-06T21:22:12Z

I'm a bit confused here - is this a new feature? - or just a backport?

new features should land in the latest branch first - then we can deal with the backports?

keevan · 2024-05-09T04:24:28Z

I'm a bit confused here - is this a new feature? - or just a backport?

new features should land in the latest branch first - then we can deal with the backports?

Good catch, I'll re-target the latest branch and create a backport PR once it's merged. Thanks Dan.

Peterburnett

I've largely reviewed the major commit, rather than the CI changes, but this one is looking good to go.

Peterburnett · 2024-05-09T05:49:31Z

@danmarsden I've approved this one, its fairly self contained, did you have anything you wanted to mention before merge?

danmarsden · 2024-05-09T08:02:54Z

if you've reviewed the full patch...and hard-coded english lang strings are fixed like this one I spotted:
https://github.com/catalyst/moodle-mod_facetoface/pull/151/files#diff-2359f56e8ab786049c0f9961df9bd8363b0f1e4e986972ebc692302ebc920000R119

then feel free to merge. :-)

db/access.php

Summary: - permission check to only allow users with this permission to do so - can intially set notification type, status (booked/cancelled) and discount code. - tests for various scenarios. - managed via a booking manager class. - supports both csv file and array (list of bookings) formats. Resolves #150

- add missing phpdocs, - optimise coursecontext get by caching the call to the class, - convert moodle_url to abs path - remove double blank lines - remove dead code - fix file upload handling

Issues fixed: 4 - Expected a space after cast statement

keevan force-pushed the 150-upload-bookings branch from 2c707ae to 6133927 Compare May 2, 2024 05:03

keevan force-pushed the 150-upload-bookings branch 2 times, most recently from afd28d4 to e1bb6c1 Compare May 2, 2024 06:32

Peterburnett reviewed May 2, 2024

View reviewed changes

classes/booking_manager.php Show resolved Hide resolved