Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: suppress cancel emails in bulk upload #174

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat: suppress cancel emails in bulk upload #174

merged 2 commits into from
Jul 9, 2024

Conversation

matthewhilton
Copy link
Contributor

Changes

  • An extension on the suppress bulk upload emails feature added in Bulk upload suppress emails #168
  • Now also suppresses cancel emails, since they are handled separately from signup emails.

Testing

  • Manual testing - passed
  • Covered by updated unit tests

@matthewhilton matthewhilton mentioned this pull request Jul 9, 2024
Merged
keevan
keevan approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @matthewhilton

@matthewhilton matthewhilton merged commit c9f07ca into MOODLE_403_STABLE Jul 9, 2024
11 checks passed
@matthewhilton matthewhilton deleted the suppress-cancel-email-43 branch July 9, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keevan keevan keevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhilton @keevan