Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore case option #180

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Ignore case option #180

merged 3 commits into from
Sep 9, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Sep 4, 2024 •
edited
Loading

Changes

  • Adds options when uploading users in csv, to match them case insensitively.
  • Default on, because Moodle also generally does not allow duplicate emails when ignoring case. So for most people, on is the most logical option.

Testing

  • Manual testing - passed
  • Also covered by unit tests

Cherry picks

@matthewhilton matthewhilton mentioned this pull request Sep 4, 2024
Merged
@Peterburnett Peterburnett merged commit a2409ae into MOODLE_400_STABLE Sep 9, 2024
15 checks passed
@Peterburnett Peterburnett deleted the ignore-case-option branch September 9, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhilton @Peterburnett