Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mute settings #187 #188

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

bwalkerl
Copy link
Contributor

@bwalkerl bwalkerl commented Aug 2, 2024

I've added these as full settings as it made more sense than config only.

Closes #187

Pull request checks

  • [Y] I have checked the version numbers are correct as per the README

@bwalkerl
Copy link
Contributor Author

bwalkerl commented Aug 2, 2024

One note - I couldn't add regex to a help button using addHelpButton as it doesn't take a parameter for the help string, so right now the regex only shows when the rule validation fails. I'm open to suggestions for other ways to show this.

@brendanheywood brendanheywood merged commit 2f05062 into MOODLE_39_STABLE Aug 5, 2024
30 checks passed
@brendanheywood brendanheywood deleted the add-mute-config-187 branch August 5, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mute exceptions optionally have a force url
2 participants