Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binning on empty reduced logs #55

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Fix binning on empty reduced logs #55

merged 3 commits into from
Aug 22, 2024

Conversation

CodyCBakerPhD
Copy link
Member

Since the reduced logs can be empty to signify the raw logs for that date were processed

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 22, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 22, 2024 05:17
@CodyCBakerPhD CodyCBakerPhD merged commit 46a6b02 into main Aug 22, 2024
3 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix_empty_log branch August 22, 2024 05:53
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (b7d35b3) to head (7814ba4).
Report is 2 commits behind head on main.

Files Patch % Lines
...g_parser/_bin_all_reduced_s3_logs_by_object_key.py 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   65.13%   64.34%   -0.79%     
==========================================
  Files          13       14       +1     
  Lines         499      561      +62     
==========================================
+ Hits          325      361      +36     
- Misses        174      200      +26     
Flag Coverage Δ
unittests 64.34% <83.33%> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g_parser/_bin_all_reduced_s3_logs_by_object_key.py 84.44% <83.33%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant