Skip to content

Commit

Permalink
Merge branch 'main' into add_roi_response_series
Browse files Browse the repository at this point in the history
  • Loading branch information
CodyCBakerPhD authored Jul 19, 2024
2 parents 6f7e49d + eea8167 commit 8daadce
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 5 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ classDiagram
--------------------------------------
data : numeric, frame x height x width
--> unit : text
depth_per_frame : numeric, length of frames
-- > unit : text, default="micrometers"
depth_per_frame_in_um : numeric, length of frames
--------------------------------------
links
Expand Down
2 changes: 1 addition & 1 deletion spec/ndx-microscopy.extensions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,6 @@ groups:
- null
- name: depth_per_frame_in_um
doc: Depth in micrometers of each frame in the data array.
These values offset the 'z' value of the `origin_coordinates` of the linked `imaging_space` object.
dtype: numeric
dims:
- depths
Expand Down Expand Up @@ -508,6 +507,7 @@ groups:
was recorded from.
target_type: VolumetricImagingSpace


- neurodata_type_def: MicroscopyResponseSeries
neurodata_type_inc: TimeSeries
doc: ROI responses extracted from optical imaging.
Expand Down
2 changes: 2 additions & 0 deletions src/pynwb/ndx_microscopy/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,11 @@
VolumetricMicroscopySeries = get_class("VolumetricMicroscopySeries", extension_name)
MultiChannelMicroscopyVolume = get_class("MultiChannelMicroscopyVolume", extension_name)
VariableDepthMultiChannelMicroscopyVolume = get_class("VariableDepthMultiChannelMicroscopyVolume", extension_name)

MicroscopyResponseSeries = get_class("MicroscopyResponseSeries", extension_name)
MicroscopyResponseSeriesContainer = get_class("MicroscopyResponseSeriesContainer", extension_name)


__all__ = [
"Microscope",
"MicroscopyLightSource",
Expand Down
2 changes: 2 additions & 0 deletions src/pynwb/ndx_microscopy/testing/_mock.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ def mock_VariableDepthMicroscopySeries(
) -> ndx_microscopy.VariableDepthMicroscopySeries:
series_name = name or name_generator("VariableDepthMicroscopySeries")
series_data = data if data is not None else np.ones(shape=(15, 5, 5))

depth_per_frame_in_um = (
depth_per_frame_in_um
if depth_per_frame_in_um is not None
Expand Down Expand Up @@ -379,6 +380,7 @@ def mock_VariableDepthMultiChannelMicroscopyVolume(
series_name = name or name_generator("MultiChannelMicroscopyVolume")

series_data = data if data is not None else np.ones(shape=(15, 5, 5))

volume_depth_per_frame_in_um = (
depth_per_frame_in_um
if depth_per_frame_in_um is not None
Expand Down
2 changes: 0 additions & 2 deletions src/pynwb/tests/test_constructors.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,7 @@ def test_constructor_variable_depth_multi_channel_microscopy_volume():
optical_channels=optical_channels_used_by_volume,
)


# TODO: add constructor tests for MicroscopyResponseSeries


if __name__ == "__main__":
pytest.main() # Required since not a typical package structure
1 change: 1 addition & 0 deletions src/pynwb/tests/test_roundtrip.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,5 +282,6 @@ def test_roundtrip(self):

# TODO: add roundtrip test for MicroscopyResponseSeries


if __name__ == "__main__":
pytest.main() # Required since not a typical package structure

0 comments on commit 8daadce

Please sign in to comment.