[Enhancement II] Compatible processed types #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Enhacement II] Testing
…able_depth_static
CodyCBakerPhD
commented
Jun 27, 2024
| Specify 'whole-brain' if the entire brain is strictly contained within the space. | ||
| Specify 'whole brain' if the entire brain is strictly contained within the space. |
There was a problem hiding this comment.
Also sneaking this change in
There was a problem hiding this comment.
From @alessandratrapani, has not seen the version with the dash, but intuitively wanted 'Whole Brain'
CodyCBakerPhD
commented
Jun 27, 2024
CodyCBakerPhD
commented
Jun 27, 2024
CodyCBakerPhD
changed the title
…able_depth_static
CodyCBakerPhD
changed the title
CodyCBakerPhD
commented
Jul 12, 2024
CodyCBakerPhD
commented
Jul 12, 2024
CodyCBakerPhD
commented
Jul 12, 2024
CodyCBakerPhD
commented
Jul 12, 2024
for more information, see https://pre-commit.ci
…github.com/catalystneuro/ndx-microscopy into all_previous_prs_and_variable_depth_static
for more information, see https://pre-commit.ci
…github.com/catalystneuro/ndx-microscopy into all_previous_prs_and_variable_depth_static
for more information, see https://pre-commit.ci
|
@alessandratrapani I added tests as well as the other items we discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plane segmenations are not compatible with the new
ImagingSpacehereRoiResponseSeriesshould be fine though since it just has a dynamic table region that can point to anything