-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/395 EDC client handle multiple DTRs and DTs #775
Conversation
Partial implementation started in context of #214 before story was split up. This commit is just meant to back up the work. It is neither complete nor does it work yet and it still contains compile errors.
this code place is not related to this story
edcRestTemplate is correct here, because we communicate with a DTR via an EDC
- better variable/parameter naming - split up stream expression into multiple lines - add helpful code comments to each part - reference special scenario diagram
And remove test concerning InterruptedException which is no longer relevant in this place.
by accessing EndpointDataReferenceStorage via EndpointDataReferenceCacheService only
CHANGELOG file was not updated! Make sure to include important changes. |
…andle-multiple-DTRs-and-DTs
Already removed dependency to EndpointDataReferenceStorage in previous commits. In order to reduce more imports more refactoring would be required which is far beyond the scope of the current story.
…andle-multiple-DTRs-and-DTs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the size of this PR it might make sense to contribute this directly to eclipse-tractusx
.../src/docs/arc42/cross-cutting/discovery-DTR--multiple-EDCs-with-multiple-DTRs--detailed.puml
Outdated
Show resolved
Hide resolved
docs/src/docs/arc42/cross-cutting/discovery-DTR--multiple-EDCs-with-multiple-DTRs.puml
Show resolved
Hide resolved
docs/src/docs/arc42/cross-cutting/discovery-DTR--multiple-EDCs-with-no-DTRs--detailed.puml
Show resolved
Hide resolved
docs/src/docs/arc42/cross-cutting/discovery-DTR--multiple-EDCs-with-no-DTRs.puml
Show resolved
Hide resolved
docs/src/docs/arc42/cross-cutting/discovery-DTR--multiple-EDCs-with-one-DTR.puml
Show resolved
Hide resolved
docs/src/docs/arc42/cross-cutting/discovery-DTR--one-EDC-with-multiple-DTRs--detailed.puml
Outdated
Show resolved
Hide resolved
docs/src/docs/arc42/cross-cutting/discovery-DTR--one-EDC-with-one-DTR--detailed.puml
Outdated
Show resolved
Hide resolved
irs-edc-client/src/main/java/org/eclipse/tractusx/irs/edc/client/EdcSubmodelFacade.java
Outdated
Show resolved
Hide resolved
…andle-multiple-DTRs-and-DTs # Conflicts: # CHANGELOG.md
this file had been committed accidently
…andle-multiple-DTRs-and-DTs # Conflicts: # irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/RelationshipDelegate.java
Quality Gate passedIssues Measures |
Closing this PR since it was contributed directly to upstream in eclipse-tractusx#462 |
…pdate-irs-registry-client-2.1.4 Update irs-registry-client to 2.1.4
eclipse-tractusx#395