Resolves issue #45 #46
Conversation
| accent_colors = [color.name for color in PALETTE.mocha.colors if color.accent == True] | ||
|
|
||
| # Create a map of red2 values since they don't exist in the catppuccin palette | ||
| red2 = {PALETTE.mocha.name: (181, 103, 125), |
There was a problem hiding this comment.
Why are we defining another red in the first place?
There was a problem hiding this comment.
Some of the cancel menu sprites have had a 2nd darker color of red used ever since the beginning of the pack since it made the visibility better (That's how it was done in the original pack). An example would be this https://github.com/catppuccin/minecraft/blob/main/resource-packs/Catppuccin%20UI/template/1.20.2/assets/minecraft/textures/gui/sprites/container/beacon/cancel.png
There was a problem hiding this comment.
I'd appreciate it if we could generate the darker red from the palette red instead of seemingly hardcoding the rgb tuple.
There was a problem hiding this comment.
I did a bit of testing around and the difference in colors is pretty similar to a -26% in lightness on paint.net, trying to figure out how to do it in the script right now.
| def darker_red(colorRGB): | ||
| hls_tuple = rgb_to_hls(*rgb_to_tuple(colorRGB)) | ||
| red2_hls_tuple = (hls_tuple[0], hls_tuple[1] * 0.74, hls_tuple[2]) | ||
| return tuple(round(i) for i in hls_to_rgb(*red2_hls_tuple)) |
There was a problem hiding this comment.
I didn't know how to do this more cleanly, would be open for anyone better to refactor this
The RGB values were pretty much +- 3 for all flavors
There was a problem hiding this comment.
I think this PR is okay to merge once the catppuccincolors.py file is removed.
There was a problem hiding this comment.
Would be nice to refactor this script at some point in the future but looks okay for now 👍
@JustLetterV Can you confirm it still works as intended and merge whenever you're free?
Removes the module catppuccincolors.py and uses the values defined in the Catppuccin python module in the script create_functions.py.