Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conan] Add header-only style conan support #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fohlen
Copy link
Contributor

@Fohlen Fohlen commented Jan 9, 2019

Add's conanfile.py via conan template

@Fohlen
Copy link
Contributor Author

Fohlen commented Jan 9, 2019

I just so copied the .github folder and believe it could also be deleted.

appveyor.yml Outdated Show resolved Hide resolved
.github/settings.yml Outdated Show resolved Hide resolved
test_package/conanfile.py Show resolved Hide resolved
.github/settings.yml Outdated Show resolved Hide resolved
.ci/install.sh Show resolved Hide resolved
.ci/run.sh Show resolved Hide resolved
conanfile.py Outdated Show resolved Hide resolved
- remove uneccesary GitHub settings
- remove AppVeyor for now since MSVC cannot build this
- add copyright notice where needed
- adjust author
env: CONAN_CLANG_VERSIONS=5.0 CONAN_DOCKER_IMAGE=conanio/clang50

install:
- chmod +x .ci/install.sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still learning conan and travis, but it seems like it would be simpler (and less fraught with license complications) to do this without the shell scripts. Something like:

language: cpp
os: linux
dist: trusty
sudo: required
addons:
  apt:
    sources:
      - ubuntu-toolchain-r-test
    packages:
      - g++-8
env: CC=gcc-8 CXX=g++-8
before_install: pip install conan
install: conan user
script: conan create . user/channel

But I'm probably missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory this could be done. However the xenial and trusty images comes with libstdc5 (or earlier) and it is cumbersome and error prone to upgrade to any more recent version (which is needed for C++17). Using a pre-backed docker with all the tools makes life much easier.

@cbbowen
Copy link
Owner

cbbowen commented Jan 19, 2019

I think having Travis set up this way doesn't quite work, because it tries to fetch the latest release archive rather than using the current code, which seems to defeat the purpose of CI. See the travis build log here: https://travis-ci.org/cbbowen/trytravis-scratch/builds/481678825.

@Fohlen
Copy link
Contributor Author

Fohlen commented Jan 19, 2019

Yup this seems wrong, I will investigate why it does not conan create . locally, which would be the intended purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants