Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong comparison in maml.py #73

Open
shufflebyte opened this issue Jan 4, 2020 · 0 comments
Open

wrong comparison in maml.py #73

shufflebyte opened this issue Jan 4, 2020 · 0 comments

Comments

@shufflebyte
Copy link

shufflebyte commented Jan 4, 2020

Hello,
I played a little with your code and I think I found an error line in your code, see maml.py in line 120: https://github.com/cbfinn/maml/blob/master/maml.py#L120

if FLAGS.norm is not 'None':

You use the string 'None' to decide if you want to do the action, but you actually compare the object FLAGS.norm (which is a string object) and 'None'. Since "is" compares if the objects are the same, the objects are never the same, so you will perform it always. I think you want to do:
if FLAGS.norm != 'None' to compare the values of both string objects.

Greetings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant