Deduplicate Pusher::try_{reserve,push} #13
Conversation
|
So, this seems like a sufficiently obvious win that I'm sitting here staring at the code, trying to figure out why I didn't do this to begin with. (That's intended as a compliment.) TBH I was probably just in a hurry, since the cancel-correctness changes happened during the frantic lead-up to finishing my sculpture in the summer. Assuming I don't notice some subtle reason for the duplication, I'm planning on merging this. |
| entry.push(value); | ||
| Ok(()) | ||
| } else { | ||
| Err(value) |
There was a problem hiding this comment.
I felt like I ought to be able to rewrite this to use Option::ok_or_else, but it just doesn't work because it'd move T. So I think this is probably the most concise way of expressing it already.
|
So, rebased this and did some testing with my firmware projects. The generated code is, while not exactly identical to before, definitely the same size, which is lovely -- sometimes the inlining heuristics do weird things for changes like this. I can't think of a reason not to do this. Thanks for the cleanup! |
No description provided.