fix: hide 'item was not checked in' warning

admin-js/circ-returns.js

@@ -4,11 +4,19 @@ if (path.match('/cgi-bin/koha/circ/returns.pl')) {
     $(function(){
         // loop over each row in the checkin table
         $('#checkedintable tr').each(function(){
-            var row = $(this)
-            var home = row.find('td.ci-homelibrary')
-            var holding = row.find('td.ci-holdinglibrary')
-            // compare home branch to branch where the item's being checked in
-            if (home.text() !== holding.text()) {
+            let row = $(this)
+
+            // 1 misleading warning when item that wasn't checked out is checked in
+            let duedate = row.find('td.ci-duedate')
+            if (duedate.find('.problem').text().toLowerCase().trim() === 'item was not checked in' &&
+                duedate.find('span').eq(1).text().toLowerCase().trim() === 'not checked out') {
+                duedate.find('.problem').hide()
+            }
+
+            // 2 extra warning for books that need to be returned to their home library
+            let home = row.find('td.ci-homelibrary')
+            let holding = row.find('td.ci-holdinglibrary')
+            if (home.text().trim() !== holding.text().trim()) {
                 // if they differ, show an alert with on-hover helper text
                 holding.addClass('error alert-error')
                     .css({'cursor': 'help', 'font-weight': 'bold'})