Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with nhanesDim, nhanesNcol, nhanesNrow #28

Open
rgentlem opened this issue Jan 7, 2024 · 1 comment
Open

issues with nhanesDim, nhanesNcol, nhanesNrow #28

rgentlem opened this issue Jan 7, 2024 · 1 comment

Comments

@rgentlem
Copy link
Contributor

rgentlem commented Jan 7, 2024

Notice here:

nhanesDim("DEMO")
[1] 9965 290
nhanesNrow("DEMO")
[1] 9965 > nhanesNcol("DEMO")
[1] 290
vv = nhanes("DEMO")
dim(vv)
[1] 9965 145
--
 
so the Ncol value and the nhanesDim answer are wrong - they have the same problem as I reported earlier.
once we retrieve the data, it has 145 columns, but both nhanesNcol and nhanesDim incorrectly report it has 290
columns.

I urge putting in more complete descriptions and tests/checks that, for example what is reported by nhnanesDim, nhanesNrow
and nhanesNcol are the same values as you would get from doing
vv = nhanes("table")
dim(vv)
nrow(vv)
ncol(vv)
this kind of unit checking is essential for ensuring that our code works

@ainilaha
Copy link
Collaborator

I don't what happened to the DB, but looks work now.

> nhanesNcol("DEMO")
[1] 145
> nhanesDim("DEMO")
[1] 9965  145
> vv = nhanes("DEMO")
> dim(vv)
[1] 9965  145

Yes, we are still missing the checking code though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants