Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/Added CMakeLists.txt file to the project #174

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

sisco0
Copy link

@sisco0 sisco0 commented Jan 24, 2022

Solves #173. Should be merged before PR #176.

A CMakeLists.txt has been added to the project with the purpose of showing a way to go on with a CMake-enabled simplified build system.

A test could be run for checking out this file system by running the following commands shown below.

  1. For CUDA builds:
cmake . -DBUILD_CUDA=1 -B../AutoDock-GPU-Build-CUDA
cmake --build ../AutoDock-GPU-Build-CUDA -j`nproc`
(cd ../AutoDock-GPU-Build-CUDA && make CTEST_OUTPUT_ON_FAILURE=1 test)
  1. For OpenCL builds:
cmake . -DBUILD_OPENCL=1 -B../AutoDock-GPU-Build-OpenCL
cmake --build ../AutoDock-GPU-Build-OpenCL -j`nproc`
(cd ../AutoDock-GPU-Build-OpenCL && make CTEST_OUTPUT_ON_FAILURE=1 test)

@sisco0 sisco0 changed the title Added CMakeLists.txt file to the project feat/Added CMakeLists.txt file to the project Jan 24, 2022
The sh file is not required
@atillack
Copy link
Member

@sisco0 Thank you for this helpful PR. It might also address #7 🙂

@sisco0
Copy link
Author

sisco0 commented Jan 30, 2022

Kindly take a look at the parent issue #173 where further steps are established at integrating this build system with the Github Actions CI.
Also, I attach a screenshot of the build and test process performed as expected with the establishment of the new test through CMake, sadly, this feature could not be tested under Github-hosted machines for CI as they do not contain OpenCL capabilities.

image

…lized pipeline) and NUMWI (number of work units) as well as defines needed for OpenCL.
@atillack
Copy link
Member

atillack commented Feb 2, 2022

@sisco0 I added C++11 flags and switched to creating symlinks as well as fixed all missing defines for OpenCL to work as well as the options for OVERLAP (parallelized pipeline using OpenMP) as well as NUMWI (number of work units).

The PR is still missing a compilation target and/or fallback for compiling in tool mode - it's a host-only binary that can be used to run XML conversion and contact analysis should no Cuda or OpenCL be available.

Integrating the OpenCL code into the binary is really the only acceptable solution so more work might still be needed for eventual Windows compilation (although Cuda should already compile).

@atillack
Copy link
Member

atillack commented Feb 2, 2022

@sisco0 Also, the release types and associated behavior (defines like DOCK_DEBUG) is still missing.

@atillack
Copy link
Member

atillack commented Feb 2, 2022

@sisco0 Please see comment in PR #176 - let's move forward with #176 and close this one.

@sisco0
Copy link
Author

sisco0 commented Feb 6, 2022

I am out of office until Tuesday, I have no inconvenience if any fellow would like to fast-forward the unique branch approach. I plan to continue contributing to the project when I be back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants