Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDAP-21114 Disable messaging service pod for new CDAP instances with Cloud Spanner enabled #15806

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sidhdirenge
Copy link
Contributor

@sidhdirenge sidhdirenge commented Jan 16, 2025

conditionally add messaging service to MonitorHandlerModule

@sidhdirenge sidhdirenge added the build Triggers github actions build label Jan 16, 2025
@sidhdirenge sidhdirenge changed the title conditionally add messaging service to MonitorHandlerModule CDAP-21114 Disable messaging service pod for new cdf instances with Cloud Spanner enabled Jan 16, 2025
@sidhdirenge sidhdirenge marked this pull request as ready for review January 16, 2025 10:32
@sidhdirenge sidhdirenge changed the title CDAP-21114 Disable messaging service pod for new cdf instances with Cloud Spanner enabled CDAP-21114 Disable messaging service pod for new CDAP instances with Cloud Spanner enabled Jan 16, 2025
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sidhdirenge sidhdirenge force-pushed the sidhdirenge-messaging-pod branch from 8c5b244 to 4a20cd2 Compare January 16, 2025 10:57
@sidhdirenge sidhdirenge force-pushed the sidhdirenge-messaging-pod branch from ced0fbf to 0aaead9 Compare January 16, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants