[CDAP-21064] Validate workflow token on program status trigger. #15810
+217
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivv
reviewed
Jan 17, 2025
| @@ -209,7 +210,7 @@ private void addNotification(Job job, Notification notification) throws IOExcept | |||
| } | |||
|
|
|||
| private boolean isTriggerSatisfied(ProgramSchedule schedule, List<Notification> notifications) { | |||
| return ((SatisfiableTrigger) schedule.getTrigger()).isSatisfied(schedule, notifications); | |||
| return ((SatisfiableTrigger) schedule.getTrigger()).isSatisfied(schedule, new NotificationContext(notifications,appMetadataStore)); | |||
| import java.io.IOException; | ||
| import java.util.List; | ||
|
|
||
| public class NotificationContext { |
| }); | ||
| public boolean isSatisfied(ProgramSchedule schedule, NotificationContext notificationContext) { | ||
| return getTriggerSatisfiedResult(notificationContext.getNotifications(), false, | ||
| new Function<ProgramRunInfo, Boolean>() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a workflow token validation for composite program status trigger.
Background
When a run completes it sends 2 messages one for program status and one for workflow token to be updated in the DB.
These messages may be out of sync causing the dependent pipeline to fail with a NPE because of missing workflow token.
This change adds a validation that constraint should only be satisfied when a workflow token is written to the DB.
Assumptions
This is based on the assumption that all pipelines add save a workflow token whenever it terminates(in both success and failure cases)
Testing
Actual state is very hard to reproduce so tried running dependent pipelines in local sandbox with scheduling pipeline1 and triggering pipeline2 whenever the first pipeline completes.