fix: broken links in markdown and typos in log messages #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quixoticmonk
force-pushed
the
fix/typos-link-references
branch
from
2cae2ef
to
cbe21b7
Compare
dontirun
requested changes
Jan 22, 2024
docs/IgnoreSuppressionConditions.md
Outdated
| @@ -102,7 +102,7 @@ A user would see the following output when attempting to synthesize an applicati | |||
|
|
|||
| `cdk-nag` exposes both a `SuppressionIgnoreAnd` class and a `SuppressionIgnoreOr` to help developers create more complicated conditions | |||
|
|
|||
| - `SuppressionIgnoreAnd`: Ignores the suppression if **ALL** of the given INagSuppressionIgnore return a non-empty message (logical and) | |||
| - `SuppressionIgnoreAnd`: Ignores the suppression if **ALL** the given INagSuppressionIgnore return a non-empty message (logical and) | |||
There was a problem hiding this comment.
This change isn't necessary. 'All of' is proper grammar
There was a problem hiding this comment.
Reverted this one and the one in Nagpacks.md
dontirun
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571