Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 87 - Pydantic version update #88

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions custom_components/givenergy_local/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"aiofiles==0.8.0",
"arrow==1.2.3",
"crccheck==1.3.0",
"pydantic==1.10.15",
"pydantic==1.10.17",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was previously fixed in #85 but broken again with new HA release.

Can I suggest pydantic>=1.10.15,==10.11.*?

Same for requirements.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: pydantic>=1.10.12,==10.11.*, to allow it to work with pre HA 2024.6

Confirmed using my own HA install
pskillen@00410b9

"aenum==3.1.12"
],
"version": "0.0.1"
}
}
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
aiofiles==0.8.0
arrow==1.2.3
crccheck==1.3.0
pydantic==1.10.15
pydantic==1.10.17
aenum==3.1.12
homeassistant