Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed subscription memory leek in useEffect by adding to the return. #14

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Fixed subscription memory leek in useEffect by adding to the return. #14

merged 1 commit into from
Aug 3, 2024

Conversation

cearps
Copy link
Owner

@cearps cearps commented Jul 29, 2024

maxjaszewski
maxjaszewski approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@maxjaszewski maxjaszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, have we documented this already?

@cearps
Copy link
Owner Author

cearps commented Aug 3, 2024

looks good, have we documented this already?

Yeah I mentioned it in here
https://student-team-sx2xae6w.atlassian.net/wiki/spaces/TMA/pages/622593/Coding+Standards#Use-of-RxJS-Observables-on-the-Frontend

@cearps cearps closed this Aug 3, 2024
@cearps cearps reopened this Aug 3, 2024
@cearps cearps merged commit bea335e into main Aug 3, 2024
8 checks passed
@cearps cearps deleted the fixing-frontend-memory-leak branch August 3, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxjaszewski maxjaszewski maxjaszewski approved these changes

Assignees

@maxjaszewski maxjaszewski

@SovannarithHayGH SovannarithHayGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cearps @maxjaszewski @SovannarithHayGH