Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the size of the progress bar and newline task edit. #64

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

SovannarithHayGH
Copy link
Collaborator

No description provided.

Copy link
Owner

@cearps cearps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@cearps cearps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please review my comment

@@ -39,6 +45,12 @@ export default function KanbanDisplay({
};
}, []);


const showNotification = (message: string, type: "success" | "error" | "info" = "info") => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to extract this to a custom type under /utils/types.tsx. I am not that fussed, so I'll leave it up to you

@SovannarithHayGH SovannarithHayGH merged commit 80c9b0c into main Oct 10, 2024
4 checks passed
@SovannarithHayGH SovannarithHayGH deleted the Fixing-the-progressbar-size branch October 10, 2024 09:48
@SovannarithHayGH SovannarithHayGH restored the Fixing-the-progressbar-size branch October 11, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants