fixed: Naturally generated campfires could crash the game #31

cech12 · Jan 30, 2024 · 63c143f · 63c143f
1 parent 1bfdb90
commit 63c143f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Forge Recommended Versioning](https://mcforge.readthedocs.io/en/latest/conventions/versioning/).
 
+## [1.20.4-2.1.0.2] - 2024-01-30
+### Fixed
+- Naturally generated campfires could crash the game #31 (thanks to hanweiyyds for the report)
+
 ## [1.20.4-2.1.0.1] - 2024-01-19
 ### Fixed
 - Startup crash in Forge (thanks to solitarybear)

diff --git a/common/src/main/java/de/cech12/unlitcampfire/mixin/CampfireBlockEntityMixin.java b/common/src/main/java/de/cech12/unlitcampfire/mixin/CampfireBlockEntityMixin.java
@@ -211,7 +211,9 @@ protected void dowseProxy(CallbackInfo info) {
         //is called by multiple sources such as shovel, water potion, water bucket extinguishing
         this.unlitCampfire$litTime = 0;
         this.unlitCampfire$rainTime = 0;
-        this.markUpdated();
+        if (this.level != null) {
+            this.markUpdated();
+        }
     }
 
 }
diff --git a/gradle.properties b/gradle.properties
@@ -4,7 +4,7 @@
 
 # Project
 group=de.cech12.unlitcampfire
-mod_version=2.1.0.1
+mod_version=2.1.0.2
 mod_id=unlitcampfire
 mod_name=Unlit Campfire
 mod_author=Cech12