Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix bugs in docker workflow #90

Merged
merged 4 commits into from
Jan 17, 2024
Merged

ci: fix bugs in docker workflow #90

merged 4 commits into from
Jan 17, 2024

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Jan 5, 2024 •
edited
Loading

Overview

Context: celestiaorg/celestia-node#2966 (comment)

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey MSevey requested a review from a team as a code owner January 5, 2024 16:24
@MSevey MSevey mentioned this pull request Jan 5, 2024
Closed
tty47
tty47 previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@tty47 tty47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! ;)

ramin
ramin previously approved these changes Jan 9, 2024
View reviewed changes
@MSevey MSevey dismissed stale reviews from ramin and tty47 via 1ac3f4e January 10, 2024 14:17
@MSevey MSevey enabled auto-merge (squash) January 10, 2024 14:20
@MSevey MSevey merged commit b88ab2a into main Jan 17, 2024
20 checks passed
@MSevey MSevey deleted the sevey/docker-fixes branch January 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tty47 tty47 tty47 approved these changes

@Bidon15 Bidon15 Bidon15 approved these changes

@ramin ramin Awaiting requested review from ramin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MSevey @ramin @Bidon15 @tty47