chore: move main to the cmd #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
suggested changes
Dec 4, 2023
There was a problem hiding this comment.
cmd/cmd feels clumsy to me, usually the pattern is to have the named output binary under cmd, so in this case, some ideas
cmd/bittwister/root.go
cmd/cli/root.go
cmd/server/root.go
something like that, i'm also of the mind that thing not related to the provisioning of the cmd should be in a package above, ie
/commands/utils/utils.go
/utils/{utils.go,cmd.go}
or similar if they can't be named.
If there is only one output binary, why not name it after the tool itself? bittwister?
yes |
MSevey
approved these changes
Dec 4, 2023
ramin
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6