Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'exportloopref' is deprecated #3918

Closed
rootulp opened this issue Sep 26, 2024 · 3 comments
Closed

'exportloopref' is deprecated #3918

rootulp opened this issue Sep 26, 2024 · 3 comments
Assignees
@kobakaku
Labels
good first issue Good for newcomers nice to have item is not blocking or required.

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 26, 2024 •
edited
Loading

Problem

On v2.x

$ make lint
--> Running golangci-lint
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

Proposal

Resolve the warning
@rootulp rootulp added good first issue Good for newcomers nice to have item is not blocking or required. labels Sep 26, 2024
@tusharnagar17
Copy link

Hi team,
I'm interested in working on this issue. Could you please assign it to me?

@kobakaku kobakaku mentioned this issue Sep 30, 2024
Closed
@kobakaku
Copy link
Contributor

kobakaku commented Sep 30, 2024 •
edited
Loading

I've done this issue.
This issue needs to address the new lint errors.

@rootulp
Copy link
Collaborator Author

rootulp commented Oct 17, 2024

Looks resolved to me on v2.x:

$ make lint
--> Running golangci-lint
--> Running markdownlint
--> Running hadolint
--> Running yamllint

@rootulp rootulp closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kobakaku kobakaku

Labels
good first issue Good for newcomers nice to have item is not blocking or required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): replace loopvar linter kobakaku/celestia-app
3 participants
@rootulp @tusharnagar17 @kobakaku