Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

celestia-appd version reports incorrect version for -arabica and -mocha tags #3933

Closed
rootulp opened this issue Oct 2, 2024 · 2 comments · Fixed by #3977
Closed

celestia-appd version reports incorrect version for -arabica and -mocha tags #3933

rootulp opened this issue Oct 2, 2024 · 2 comments · Fixed by #3977
Assignees
@rootulp
Labels
bug Something isn't working

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 2, 2024

Problem

$ gco v2.2.0-mocha
$ make install
$ celestia-appd version
2.2.0-arabica

Proposal

Fix the version command so that it reports 2.2.0-mocha
@rootulp rootulp added the bug Something isn't working label Oct 2, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Oct 7, 2024

Related: celestiaorg/celestia-node#3820

@rootulp rootulp self-assigned this Oct 14, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Oct 15, 2024 •
edited
Loading

Looks like it was broken for -rc0 too.

$ ./celestia-appd-v2.2.0-rc0 version
2.2.0-arabica
$ ./celestia-appd-v2.2.0-arabica version
2.2.0-arabica
$ ./celestia-appd-v2.2.0-mocha version
2.2.0-arabica
$ ./celestia-appd-v2.2.0 version
2.2.0

@rootulp rootulp mentioned this issue Oct 15, 2024
Merged
rootulp added a commit that referenced this issue Oct 16, 2024
@rootulp
fix: version for tags with -arabica, -mocha, -rc suffixes (#3977)
3d49b60 
Closes #3933

## Testing 

```
$ git checkout v2.2.0-mocha
$ make debug-version
GIT_TAG: v2.2.0-mocha
VERSION: 2.2.0-mocha
$ git tag --delete v2.2.0-mocha
Deleted tag 'v2.2.0-mocha' (was d3f8b29)
$ make debug-version
GIT_TAG: v2.2.0-arabica
VERSION: 2.2.0-arabica
$ git tag --delete v2.2.0-arabica
Deleted tag 'v2.2.0-arabica' (was d3f8b29)
$ make debug-version
GIT_TAG: v2.2.0-rc0
VERSION: 2.2.0-rc0
$ git tag --delete v2.2.0-rc0
Deleted tag 'v2.2.0-rc0' (was d3f8b29)
$ make debug-version
GIT_TAG: v2.1.2-4-gd3f8b2997
VERSION: 2.1.2-4-gd3f8b2997
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: version for tags with -arabica, -mocha, -rc suffixes rootulp/celestia-app
1 participant
@rootulp