-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export BroadcastPayForBlob to support more async blob submission. (backport #3459) #3463
Conversation
Cherry-pick of 40dd8a1 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Auto Review SkippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -151,16 +151,25 @@ func (s *Signer) SubmitTx(ctx context.Context, msgs []sdktypes.Msg, opts ...TxOp | |||
|
|||
// SubmitPayForBlob forms a transaction from the provided blobs, signs it, and submits it to the chain. | |||
// TxOptions may be provided to set the fee and gas limit. | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflicts
This backport is no longer needed as we already have this method in place from the multi account signer work. celestia-app/pkg/user/tx_client.go Line 190 in 21b5bc7
|
Overview
This PR exports an existing function to block on submitting a PFB to the mempool, but not block on getting the tx included in a block.
This is an automatic backport of pull request #3459 done by [Mergify](https://mergify.com).