-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add (start share == end share) check in parse namespace (backport #3709) #3710
Conversation
Cherry-pick of 535802c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
a09a521
to
2cab538
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.x #3710 +/- ##
==========================================
+ Coverage 16.61% 17.90% +1.29%
==========================================
Files 179 189 +10
Lines 19788 20834 +1046
==========================================
+ Hits 3288 3731 +443
- Misses 16189 16787 +598
- Partials 311 316 +5 ☔ View full report in Codecov by Sentry. |
Overview
The start share shouldn't be equal to the end share because the range is end-exclusive. This PR adds this check.
This is an automatic backport of pull request #3709 done by [Mergify](https://mergify.com).