Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go.mod): bump grafana/pyroscope-go deps (backport #3849) #3854

Closed
wants to merge 1 commit into from

Commits on Sep 10, 2024

  1. chore(go.mod): bump grafana/pyroscope-go deps (#3849)

    On Go 1.23 I got such failures:
    
    ```
    % make build
    --> Updating go.mod
    --> Updating go.mod in ./test/interchain
    # github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
    ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/delta_mutex.go:30:20: undefined: runtime_cyclesPerSecond
    ../../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.6/internal/pprof/proto.go:320:8: undefined: runtime_expandFinalInlineFrame
    make: *** [build] Error 1
    ```
    
    Due to recent change in Go 1.23 where Go team removed some internal
    things. Simple bump works fine.
    
    (cherry picked from commit 2c74ea5)
    
    # Conflicts:
    #	go.mod
    #	go.sum
    cristaloleg authored and mergify[bot] committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e798665 View commit details
    Browse the repository at this point in the history