Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statesync): extract app version from snapshot #3871

Draft
wants to merge 11 commits into
base: v2.x
Choose a base branch
from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 12, 2024

Closes #3818
Blocked on celestiaorg/celestia-core#1477

Testing

I verified that logs added in this PR show up when state syncing on Mocha. The logs show that the app version provided in the OfferSnapshot ABCI method was plumbed through correctly.

./scripts/mocha.sh
...
2:44PM INF Offering snapshot to ABCI app format=2 hash="$�ڢ�\x1b� �zΊ\x15���`��왹\b^G:\x03+ߢޯ" height=2782000 module=statesync
2:44PM INF offering snapshot app_version=2 height=2782000
2:44PM INF mounting keys for snapshot app_version=2

@rootulp rootulp self-assigned this Sep 12, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Sep 26, 2024

This will be ready for review after celestiaorg/celestia-core#1477 merges, I cut a release, bump to it here. 🤞 that fixes golangci-lint too.

@rootulp rootulp added the warn:blocked item is not currently being worked on but is still blocked label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn:blocked item is not currently being worked on but is still blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant