Skip to content

Commit

Permalink
chore: remove outdated TODO (#1392)
Browse files Browse the repository at this point in the history
Closes #1391
  • Loading branch information
rootulp authored Jun 17, 2024
1 parent fb9d656 commit cc8842f
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions state/execution.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,8 @@ func (blockExec *BlockExecutor) CreateProposalBlock(

evidence, evSize := blockExec.evpool.PendingEvidence(state.ConsensusParams.Evidence.MaxBytes)

// Fetch a limited amount of valid txs
maxDataBytes := types.MaxDataBytes(maxBytes, evSize, state.Validators.Size())

// TODO(ismail): reaping the mempool has to happen in relation to a max
// allowed square size instead of (only) Gas / bytes
// maybe the mempool actually should track things separately
// meaning that CheckTx should already do the mapping:
// Tx -> Txs, Message
// https://github.com/tendermint/tendermint/issues/77
txs := blockExec.mempool.ReapMaxBytesMaxGas(maxDataBytes, maxGas)

var timestamp time.Time
Expand Down

0 comments on commit cc8842f

Please sign in to comment.