Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding the ability to prune the tx index #1070

Closed
evan-forbes opened this issue Aug 31, 2023 · 3 comments
Closed

Consider adding the ability to prune the tx index #1070

evan-forbes opened this issue Aug 31, 2023 · 3 comments

Comments

@evan-forbes
Copy link
Member

We've gone back and forth on the default tx index value in the config.toml, and now we're going back to using "null" in celestiaorg/celestia-app#2322. One of the main reasons not to enable this is because there currently is no pruning for the txindex, so the amount of block data stored is double what it would be if we didn't prune block data.

Another alternative would be to only store the txs once in the index, and then store hashes in the block data.

We should probably wait until "the merge", before making any dramatic changes to how comet handles block data give our plan is store block data once in the share format used in the square encoding.

@cmwaters
Copy link
Contributor

I think we should just implement a secondary index for the transaction hash so that users can work out whether their transaction has been committed or not (right now this is not possible).

cmwaters pushed a commit that referenced this issue Sep 20, 2023
)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.22.0 to 1.23.1.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.22.0...v1.23.1)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cmwaters
Copy link
Contributor

cmwaters commented Jan 2, 2024

This is possible duplicated here: #1065

@evan-forbes
Copy link
Member Author

closing in favor of #1163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants