-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add dupword CI && remove repetitive words globally #1331
base: main
Are you sure you want to change the base?
Conversation
thanks for this @goofylfg, all changes to comet specific logic should be pushed upstream to https://github.com/cometbft/cometbft so that all forks (including this one) can benefit 🙂 also, in general I think adding CI to fix this issue permanently instead of having one off fixes every now and again thanks! |
agree!,but have tow points want to discuss:
|
similar to celestiaorg/celestia-node#3360 |
@@ -257,7 +257,7 @@ func TestValidatorSimpleSaveLoad(t *testing.T) { | |||
assert.Nil(err, "expected no err at height 2") | |||
assert.Equal(v.Hash(), state.NextValidators.Hash(), "expected validator hashes to match") | |||
|
|||
// Increment height, save; should be able to load for next & next next height. | |||
// Increment height, save; should be able to load for next & next height. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one was intentional
// Increment height, save; should be able to load for next & next height. | |
// Increment height, save; should be able to load for next & one after next height. |
Description
use https://github.com/Abirdcfly/dupword to check duplicate words && check it manually to avoid false positve.
PR checklist
.changelog
(we useunclog to manage our changelog)
docs/
orspec/
) and code comments