-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve request prepare proposal comments #1393
chore: improve request prepare proposal comments #1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits about the field names in the descriptions.
// block_data is an array of transactions that will be included in a block, | ||
// sent to the app for possible modifications. | ||
// applications can not exceed the size of the data passed to it. | ||
// BlockData is a slice of candidate transactions that may be included in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]
// BlockData is a slice of candidate transactions that may be included in a | |
// block_data is a slice of candidate transactions that may be included in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tendermint.types.Data block_data = 1; | ||
// If an application decides to populate block_data with extra information, they can not exceed this value. | ||
// BlockDataSize is the maximum size (in bytes) that BlockData should be. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]
// BlockDataSize is the maximum size (in bytes) that BlockData should be. | |
// block_data_size is the maximum size (in bytes) that BlockData should be. |
Closes #1390