chore: backport tx status #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninabarbakadze
force-pushed
the
nina/backport-tx-status
branch
from
1d2e339
to
0f61c93
Compare
ninabarbakadze
requested review from
rootulp,
rach-id and
cmwaters
and removed request for
a team and
rach-id
rach-id
reviewed
Jul 1, 2024
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
Thanks for the review! Here are the links to the work I'm backporting from main: |
rach-id
approved these changes
Jul 1, 2024
| @@ -17,6 +17,13 @@ import ( | |||
| "github.com/tendermint/tendermint/types" | |||
| ) | |||
|
|
|||
| const ( | |||
| txStatusUnknown string = "UNKNOWN" | |||
There was a problem hiding this comment.
[non-blocking][microscopic nit]
probably document the cases where the status is unknown
Comment on lines
+66
to
+69
| Height int64 `json:"height"` | ||
| Index uint32 `json:"index"` | ||
| ExecutionCode uint32 `json:"execution_code"` | ||
| Status string `json:"status"` |
There was a problem hiding this comment.
[non blocking]
maybe document these
Opened an issue #1406 |
cmwaters
approved these changes
Jul 1, 2024
rootulp
approved these changes
Jul 1, 2024
ninabarbakadze
merged commit b1d52fd
into
celestiaorg:v0.34.x-celestia
18 of 19 checks passed
4 tasks
rootulp
pushed a commit
to rootulp/celestia-core
that referenced
this pull request
Sep 20, 2024
…tiaorg#1405) (celestiaorg#1407) * doc: improve documentation of BlockParams.MaxBytes (manual backport of celestiaorg#1405) * Applying @sergio-mena suggestion Co-authored-by: Sergio Mena <sergio@informal.systems> * Applying @jmalicevic suggestion Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com> --------- Co-authored-by: Sergio Mena <sergio@informal.systems> Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport TxStatus work from main