-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace NMTProof with Proof in nmt #1432
base: main
Are you sure you want to change the base?
Conversation
Currently it's not possible to exclude files via |
20272e8
to
aea3118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the status here? @Eoous
I have replaced it and need to review |
@@ -0,0 +1,22 @@ | |||
syntax="proto3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is to import the proto file from the nmt repository: https://github.com/celestiaorg/nmt/blob/main/pb/proof.proto instead of copy pasting the definition here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best way is uploading nmt to BSR
Description
Use Proof in nmt instead of NMTProof.
Changed
Makefile
for removing protobuf file generated by buf.Resolves #1429
PR checklist
.changelog
(we useunclog to manage our changelog)
docs/
orspec/
) and code comments