-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace NMTProof with Proof in nmt #1432
Open
Eoous
wants to merge
4
commits into
celestiaorg:main
Choose a base branch
from
Eoous:duplicate-nmt-proof
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
syntax="proto3"; | ||
|
||
package nmt; | ||
|
||
option go_package = "github.com/celestiaorg/nmt/pb"; | ||
|
||
message Proof { | ||
// Start index of the leaves that match the queried namespace.ID. | ||
int64 start = 1; | ||
// End index (non-inclusive) of the leaves that match the queried | ||
// namespace.ID. | ||
int64 end = 2; | ||
// Nodes hold the tree nodes necessary for the Merkle range proof. | ||
repeated bytes nodes = 3; | ||
// leaf_hash contains the namespace.ID if NMT does not have it and | ||
// it should be proven. leaf_hash is necessary to prove the Absence Proof. | ||
// This field will be empty in case of Inclusion Proof. | ||
bytes leaf_hash = 4; | ||
// The is_max_namespace_ignored flag influences the calculation of the | ||
// namespace ID range for intermediate nodes in the tree. | ||
bool is_max_namespace_ignored=5; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea is to import the proto file from the nmt repository: https://github.com/celestiaorg/nmt/blob/main/pb/proof.proto instead of copy pasting the definition here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best way is uploading nmt to BSR