chore: fix go doc function name #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luozexuan
requested review from
cmwaters and
staheri14
and removed request for
a team
rootulp
previously approved these changes
Aug 9, 2024
There was a problem hiding this comment.
It may be possible to upstream some of these fixes to https://github.com/cometbft/cometbft
Signed-off-by: luozexuan <fetchcode@139.com>
auto-merge was automatically disabled
August 15, 2024 08:48
Head branch was pushed to by a user without write access
luozexuan
force-pushed
the
v0.34.x-celestia
branch
from
cbe7050
to
46f9c6f
Compare
Thank you for your prompt. I have checked the comet repository and found that the names of the other two methods have been modified |
rootulp
approved these changes
Aug 15, 2024
ninabarbakadze
approved these changes
Aug 27, 2024
rootulp
changed the title
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Celestia Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
rach-id
pushed a commit
that referenced
this pull request
Nov 18, 2024
## Description fix some function names --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments Signed-off-by: luozexuan <fetchcode@139.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix some function names
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments