fix: use updateRoundStep to track consensus state changes #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
requested review from
rootulp and
rach-id
and removed request for
a team
rootulp
approved these changes
Aug 27, 2024
rach-id
approved these changes
Aug 27, 2024
staheri14
reviewed
Aug 27, 2024
| @@ -1518,6 +1515,7 @@ func (cs *State) enterPrecommitWait(height int64, round int32) { | |||
| defer func() { | |||
| // Done enterPrecommitWait: | |||
| cs.TriggeredTimeoutPrecommit = true | |||
| cs.updateRoundStep(round, cstypes.RoundStepPrecommitWait) | |||
| cs.newStep() | |||
There was a problem hiding this comment.
We also trace round step changes in newStep(), wouldn't that cause duplicates?
There was a problem hiding this comment.
I misread the code, the change is fine! I think it causes duplicate entries in the traced data.
staheri14
approved these changes
Aug 27, 2024
staheri14
reviewed
Aug 27, 2024
| @@ -538,6 +538,7 @@ func (cs *State) updateRoundStep(round int32, step cstypes.RoundStepType) { | |||
| } | |||
| if cs.Step != step { | |||
| cs.metrics.MarkStep(cs.Step) | |||
| schema.WriteRoundState(cs.traceClient, cs.Height, round, uint8(step)) | |||
There was a problem hiding this comment.
I guess my previous question applies here: Isn't updateRoundStep always followed by newStep? Then we already trace changes in newStep which means we will have duplicates?
There was a problem hiding this comment.
This is not always the case. For instance I notice the NewRound steo was never triggered and also the PrecommitWait step
There was a problem hiding this comment.
Oh and I removed the tracing from newStep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using
newStepto indicate whether to write a new trace, however this actually doesn't track when the round and step change happens and thus misses certain steps (like NewRound). This PR fixes it