Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make it easier to fetch upstream changes #1505

Open
wants to merge 6 commits into
base: v0.34.x-celestia
Choose a base branch
from

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Sep 25, 2024

Closes #1504 by deleting a bunch of files that we don't need to maintain in this fork.

@rootulp rootulp self-assigned this Sep 25, 2024
@rootulp rootulp requested a review from a team as a code owner September 25, 2024 18:08
@rootulp rootulp requested review from rach-id and evan-forbes and removed request for a team September 25, 2024 18:08
evan-forbes
evan-forbes previously approved these changes Sep 25, 2024
rach-id
rach-id previously approved these changes Sep 25, 2024
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+15 −10,259 🎉

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 25, 2024

CI is failing :(

Also upgrade checkout to v4
@rootulp rootulp dismissed stale reviews from rach-id and evan-forbes via bffb8d3 September 25, 2024 19:41
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind merging this because I don't think any of this is relevant but I'm curious, does this actually make it easier to fetch upstream changes?

@rootulp
Copy link
Collaborator Author

rootulp commented Sep 25, 2024

I think it should make it slightly easier b/c we won't have to resolve merge conflicts in these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to pull upstream changes
4 participants